Allow custom HTTP headers in BOSH and WebSockets #2907
Conversation
| %% Uncomment to enable connection dropping, server-side pings | ||
| %% and/or custom HTTP headers. Header names must be lowercase. | ||
| % {timeout, 600000}, {ping_rate, 60000}, | ||
| % {custom_headers, [{"access-control-Request-origin", "*"}]} |
There was a problem hiding this comment.
I gotta lowercase this R
| @@ -122,14 +122,20 @@ | |||
| {transport_options, [{max_connections, 1024}, {num_acceptors, 10}]}, | |||
| {modules, [ | |||
|
|
|||
| {"_", "/http-bind", mod_bosh}, | |||
There was a problem hiding this comment.
Any thoughts on how you want it written for TOML? The precedent in mod_revproxy is tuple list of headers. I cannot tell if you're gonna move that mod to TOML or drop it.
Since Cowboy natively uses maps HTTP headers, I'd like to map the headers as a map in the TOML. Will that work, even if I stray from the extra headers convention in mod_revproxy?
There was a problem hiding this comment.
The whole mod_revproxy functionality is deprecated and will be dropped in the next release unless a new demand appears (which is unlikely). Custom headers would need to be added to TOML as a table (which is parsed as a map by tomerl). However, the whole TOML parser is being rewritten at the moment and a part of this code would need to be rewritten, unless you merge this PR to the toml-config branch.
There was a problem hiding this comment.
I'll wait until #2929 is merged. I don't think it'd make sense to pollute that branch with this change, which is more functionality than config. I also plan on adding some default security headers like:
{ws_https_custom_headers, "[[listen.http.handlers.mod_websockets.custom_headers]]
strict-transport-security: "max-age=31536000 ; includeSubDomains"
"}.to the HTTPS endpoints as part of the standard as part of the standard vars-tool.config.in.
| %% Upgrade to cowboy_loop behaviour to enable long polling | ||
| {cowboy_loop, Req, #rstate{}}. | ||
| {cowboy_loop, Req, #rstate{custom_headers = CustomHeaders}}. |
There was a problem hiding this comment.
I think we can use cowboy_req:set_resp_headers here instead of passing State everywhere.
| -define(BOSH_BIND_PATH, "/http-bind"). | ||
| -define(HANDSHAKE_TIMEOUT, 3000). | ||
| -define(eq(E, I), ?assertEqual(E, I)). | ||
| -define(FAST_PING_RATE, 500). |
There was a problem hiding this comment.
Some of these defines can be removed. I suspect it's a direct copy & paste from websockets suite? :)
|
@varnerac: Any news on it? |
I am about to return to this PR. I am just tied up in another project at the moment. |
|
@varnerac: Do not forget ^^ |
This PR adds custom HTTP headers to BOSH and WebSockets endpoints
Proposed changes include:
mongooseim.cfgof how to add the custom HTTP headersmod_boshandmod_websocketsto add the customer headers to responsesWhat's missing is docs at this point.