Feature/hbm offset #186
Merged
Feature/hbm offset #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jahofmann
requested changes
May 4, 2020
wirthjohannes
force-pushed
the
feature/hbm_offset
branch
from
9d4d7fd
to
e561865
Compare
jahofmann
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically add address offsetting when connecting PEs with HBM memory.
This is necessary because the HBM blocks form a continous address space, so only the first HBM block starts at address 0.
By automatically offsetting the addresses, the address space each PE "sees" starts at 0 nevertheless.
Fixes #180
With heterogenous memory support (#181) this might be fixed in a more universal way. But for now this at least allows to use HBM with multiple PEs