New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix format typo in Structure.dump() #269

Open

laomaiweng wants to merge 1 commit into erocarrera:master from laomaiweng:patch-1

laomaiweng commented Aug 21, 2019

'{#:8X}'.format(val) yields a KeyError exception complaining about the #.

Alternate-form # format specifier should come after the colon, so this PR fixes this which seems to be a mere typo.


          Fix format typo in Structure.dump()

56aecd3

Alternate-form `#` format specifier should come after the colon.

malwarefrank commented Sep 11, 2019

I suggest changing "8" to "10" in that one line, since the prefix (0X) will use two characters. That would also makes it align better in the output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment