Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Eyeglass to ^3.0.0 and Sass to ^1.18.0 #1

Closed

Conversation

Kuresov
Copy link

@Kuresov Kuresov commented Jun 11, 2022

node-sass is deprecated (see this post and this issue) which prevents dependencies from being installed. Since https://github.com/ernieayala/ernies-modern-layout depends on teq-tonic, it causes the same node-gyp installation failure.

I have verified that deps install correctly, but let me know if you would prefer a different semver for this. Additionally, I'm not a strong JS/frontend person--is there a good way to verify these changes? Dart Sass should have the same API.

@Kuresov Kuresov force-pushed the kuresov/update-deps-06-2022 branch from 4d28f88 to 5d537b0 Compare June 11, 2022 18:57
@Kuresov Kuresov force-pushed the kuresov/update-deps-06-2022 branch from 5d537b0 to 1096572 Compare June 18, 2022 04:14
@Kuresov
Copy link
Author

Kuresov commented Aug 9, 2022

Bump on this--let me know if there are any concerns. I've been using it on a fork for https://github.com/ernieayala/ernies-modern-layout without issue so far.

@Kuresov Kuresov closed this Jul 19, 2023
@Kuresov Kuresov deleted the kuresov/update-deps-06-2022 branch July 19, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant