kernel: Fix broken wcwidth for wide chars #8382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On OSs with old libc, the wcwidth will return -1 for most/all emoji characters even if they are known to be wide characters. So we add a check that if -1 is returned for something that is known to be wide, we return 2 in size instead of 0.
CT Test Results 2 files 67 suites 1h 3m 3s ⏱️ Results for commit 0e32395. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
garazdawi
added
the
testing
garazdawi
deleted the
lukas/kernel/fix-tty-wcwidth-not-printable-wide-characters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On OSs with old libc, the wcwidth will return -1 for most/all emoji characters even if they are known to be wide characters. So we add a check that if -1 is returned for something that is known to be wide, we return 2 in size instead of 0.