Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Nicki Faulk.json #141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

harleykin
Copy link

Submitting my site for consideration. Thanks!

Submitting my site for consideration.  Thanks!
@ericwbailey
Copy link
Owner

Hi @harleykin, thanks for submitting this. I noticed a few accessibility errors on your page, namely:

  • The intro/header graphic does not have alt text supplied.
  • The webring links use the title attribute.
  • The webring links use target="_blank" declarations.

These represent access issues, and I'm consequently going to hold off on merging until they're addressed.

@harleykin
Copy link
Author

Hi @ericwbailey, thanks for the response! I could have sworn the graphic had alt text, so I will def doublecheck that!

I add title tags to the webring links because I figure not everyone knows what those symbols mean. And the blank target is my personal preference because when I'm surfing, I like to open new links in a new tab because I'm likely not done looking at/reading the current page.

If that's a deal breaker, I understand. Feel free to reject my submission. I respect what you're doing and no hard feelings. :)

-- Nicki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants