feat: support setting uc openapi session #6347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfwn
requested changes
May 15, 2024
| UCRedirectAddrs []string `file:"uc_redirect_addrs"` | ||
| SessionCookieName string `file:"session_cookie_name"` | ||
| SessionCookieDomains []string `file:"session_cookie_domain"` | ||
| CookieMaxAge time.Duration `file:"cookie_max_age" default:"24h" desc:"max age of the CSRF cookie. optional."` |
| SessionCookieDomains []string `file:"session_cookie_domain"` | ||
| CookieMaxAge time.Duration `file:"cookie_max_age" default:"24h" desc:"max age of the CSRF cookie. optional."` | ||
| // CookieSameSite default set to 2, which is `lax`, more options see https://github.com/golang/go/blob/619b419a4b1506bde1aa7e833898f2f67fd0e83e/src/net/http/cookie.go#L52-L57 | ||
| CookieSameSite int `file:"cookie_same_site" default:"2" desc:"indicates if CSRF cookie is SameSite. optional."` |
chengjoey
force-pushed
the
feat/uc-session
branch
from
a0c432d
to
dfc8f7b
Compare
sfwn
approved these changes
May 15, 2024
|
/approve |
erda-bot
approved these changes
May 15, 2024
chengjoey
added a commit
to chengjoey/erda
that referenced
this pull request
May 15, 2024
support setting uc openapi session
erda-bot
pushed a commit
that referenced
this pull request
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
support setting uc openapi session
Specified Reviewers:
/assign @sfwn
ChangeLog
Need cherry-pick to release versions?
Add comment like
/cherry-pick release/1.0when this PR is merged.