Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct plural form for zero #7925

Merged
merged 1 commit into from
May 21, 2024
Merged

Use correct plural form for zero #7925

merged 1 commit into from
May 21, 2024

Conversation

berland
Copy link
Contributor

@berland berland commented May 16, 2024

If there are no forward_model_steps, we should write '0 steps', not '0 step'

Issue
Resolves remainder of #7911

Approach
Fix.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland self-assigned this May 16, 2024
@berland berland added the release-notes:skip If there should be no mention of this in release notes label May 16, 2024
If there are no forward_model_steps, we should write '0 steps', not '0 step'
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.37%. Comparing base (4681ad7) to head (cb5b550).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7925      +/-   ##
==========================================
- Coverage   85.37%   85.37%   -0.01%     
==========================================
  Files         381      381              
  Lines       23706    23709       +3     
  Branches      884      892       +8     
==========================================
+ Hits        20240    20242       +2     
- Misses       3353     3360       +7     
+ Partials      113      107       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berland berland enabled auto-merge (rebase) May 16, 2024 19:30
@berland berland requested a review from dafeda May 21, 2024 05:14
Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@berland berland merged commit 4f015a6 into equinor:main May 21, 2024
38 checks passed
@berland berland deleted the zerosteps branch May 29, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Status: Done-Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants