Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove C Torque driver and tests #7919

Merged
merged 1 commit into from
May 22, 2024

Conversation

jonathan-eq
Copy link
Contributor

@jonathan-eq jonathan-eq commented May 16, 2024

Issue
Resolves #7912

Approach
✂️

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@jonathan-eq jonathan-eq added release-notes:maintenance Automatically categorise as maintenance change in release notes scheduler labels May 16, 2024
@jonathan-eq jonathan-eq self-assigned this May 16, 2024
@jonathan-eq jonathan-eq force-pushed the remove-legacy-torque-tests branch 6 times, most recently from 1044746 to bf9839f Compare May 21, 2024 05:52
@jonathan-eq jonathan-eq marked this pull request as ready for review May 21, 2024 07:01
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.86%. Comparing base (338202e) to head (cbca4d2).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7919      +/-   ##
==========================================
+ Coverage   85.38%   85.86%   +0.48%     
==========================================
  Files         381      378       -3     
  Lines       23593    23027     -566     
  Branches      881      633     -248     
==========================================
- Hits        20144    19772     -372     
+ Misses       3335     3177     -158     
+ Partials      114       78      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berland
Copy link
Contributor

berland commented May 21, 2024

Do we know if some of the test codes deleted here have not (yet?) been ported to the new Scheduler?

@berland
Copy link
Contributor

berland commented May 21, 2024

Should there be changes to ert/config/parsing/queue_system.py as well?

@jonathan-eq
Copy link
Contributor Author

Should there be changes to ert/config/parsing/queue_system.py as well?

It is used by scheduler too, so I cannot change too much there unless I split it into LegacyQueueSystem and SchedulerQueueSystem. I tried doing this, and it created mypy typing issues. There is probably a better way around this, but I am not sure how much work should be put into it when it is going away regardless.

@jonathan-eq
Copy link
Contributor Author

jonathan-eq commented May 21, 2024

Do we know if some of the test codes deleted here have not (yet?) been ported to the new Scheduler?

I will double check!
@berland
Our test suite for the OpenPBS driver is way more thorough, so we are covering everything the old tests did and a lot more.

Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@berland
Copy link
Contributor

berland commented May 21, 2024

Before merge, do we need to also disable some Torque testing in komodo-releases/.github/workflows?

@jonathan-eq
Copy link
Contributor Author

jonathan-eq commented May 22, 2024

Before merge, do we need to also disable some Torque testing in komodo-releases/.github/workflows?

Yes, let's merge this one first: https://github.com/equinor/komodo-releases/pull/5810

@jonathan-eq jonathan-eq merged commit a013666 into equinor:main May 22, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove TORQUE driver and tests from JobQueue
3 participants