Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin xarray #7903

Merged
merged 1 commit into from
May 21, 2024
Merged

Unpin xarray #7903

merged 1 commit into from
May 21, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented May 15, 2024

Issue
Resolves #7869

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@larsevj larsevj added the release-notes:skip If there should be no mention of this in release notes label May 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.34%. Comparing base (338202e) to head (f4fb29d).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7903      +/-   ##
==========================================
- Coverage   85.38%   85.34%   -0.04%     
==========================================
  Files         381      381              
  Lines       23593    23705     +112     
  Branches      881      893      +12     
==========================================
+ Hits        20144    20232      +88     
- Misses       3335     3366      +31     
+ Partials      114      107       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Set dimensions order on conversion to dataframe.
@larsevj larsevj force-pushed the unpin_xarray branch 2 times, most recently from f4fb29d to 118d24d Compare May 21, 2024 12:58
Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM💪

@larsevj larsevj merged commit 398bae8 into equinor:main May 21, 2024
76 checks passed
@larsevj larsevj deleted the unpin_xarray branch May 21, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin xarray
3 participants