Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default MAX_SUBMIT to 1 #7902

Merged
merged 1 commit into from
May 25, 2024
Merged

Change default MAX_SUBMIT to 1 #7902

merged 1 commit into from
May 25, 2024

Conversation

berland
Copy link
Contributor

@berland berland commented May 15, 2024

We do not want resubmission to happen by default for realizations that fail. Forward model setups may or may not be compatible with resubmissions, and flakyness should not be assumed by default.

Issue
Resolves no issue, but is in line with default configured behaviour for onprem users.

Approach
:doit:

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland added the release-notes:misc Automatically categorise as miscellaneous change in release notes label May 15, 2024
@berland berland self-assigned this May 15, 2024
We do not want resubmission to happen by default for realizations that
fail. Forward model setups may or may not be compatible with
resubmissions, and flakyness should not be assumed by default.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.81%. Comparing base (bf6d58c) to head (e2eadf1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7902      +/-   ##
==========================================
- Coverage   85.81%   85.81%   -0.01%     
==========================================
  Files         378      378              
  Lines       23073    23073              
  Branches      629      620       -9     
==========================================
- Hits        19801    19800       -1     
+ Misses       3199     3192       -7     
- Partials       73       81       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berland
Copy link
Contributor Author

berland commented May 24, 2024

Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't really checked but I hope those are all the occurrences :)
God job! 🚀

@berland berland merged commit 23fc482 into equinor:main May 25, 2024
38 checks passed
@berland berland deleted the max_submit_1 branch May 29, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:misc Automatically categorise as miscellaneous change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants