Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bug template #7884

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented May 13, 2024

After going through the bug reports we have had so far, quite a lot of the placeholder text is kept in place rather than being replaced. In order to avoid clutter, placeholder text is replaced by textareas. You can see these textareas in action in the xarray repo.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren added the release-notes:skip If there should be no mention of this in release notes label May 13, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.42%. Comparing base (bd52a37) to head (f2c6e08).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7884      +/-   ##
==========================================
+ Coverage   85.41%   85.42%   +0.01%     
==========================================
  Files         381      381              
  Lines       23565    23565              
  Branches      887      893       +6     
==========================================
+ Hits        20128    20131       +3     
+ Misses       3330     3327       -3     
  Partials      107      107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants