-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version 10 highlights to release notes #7875
Conversation
6823b02
to
99eda26
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7875 +/- ##
==========================================
+ Coverage 76.08% 85.40% +9.32%
==========================================
Files 381 381
Lines 23560 23560
Branches 885 886 +1
==========================================
+ Hits 17926 20122 +2196
+ Misses 5525 3326 -2199
- Partials 109 112 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some smaller comments.
docs/about/release_notes.rst
Outdated
###################################### | ||
|
||
The Manage experiments tool has become nicer to work with. Before you would just get text information about each experiment: | ||
![Screenshot from 2024-04-30 08-49-37](https://github.com/equinor/ert/assets/32731672/5db26f19-e772-4178-85ba-670b35a21e8b) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not render correctly I think?
docs/about/release_notes.rst
Outdated
Click on the square for the long running realization, 0 in the image: | ||
|
||
.. image:: click-on-realization.png | ||
|
||
Now click the "OPEN" button in the column STDERR for row ECLIPSE100: | ||
|
||
.. image:: click-on-stderr.png | ||
|
||
If the message contains "Eclipse failed due to license failure, retrying in XXs" then the license server is busy and we will automatically retry running eclipse in the specified number of seconds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest merging these two images, as it is hard to tell in the first image where to press, while in the second there is a blue highlight around the realization. Suggest also adding a blue border around STDERR and having some numbers next to where to press.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
docs/about/release_notes.rst
Outdated
The Manage experiments tool has become nicer to work with. Before you would just get text information about each experiment: | ||
![Screenshot from 2024-04-30 08-49-37](https://github.com/equinor/ert/assets/32731672/5db26f19-e772-4178-85ba-670b35a21e8b) | ||
.. image:: v9_manage_experiments.png | ||
|
||
Now there is a separate panel for viewing the information: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest a little rewrite, something along the lines of:
More information has been added to the Experiment manager tool, a new panel has been added with more information about about the experiment and ensembles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or if you want to embellish:
The interface for the Manage Experiments tool has been improved to provide more information about ensembles and experiments.
A new panel has been introduced, which is dedicated to displaying detailed information for each experiment. This streamlines the process of reviewing and analyzing experiment data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
99eda26
to
962d739
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delicate work! 🎨
Issue
Resolves #7770
When applicable