Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version 10 highlights to release notes #7875

Merged
merged 1 commit into from
May 21, 2024

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented May 13, 2024

Issue
Resolves #7770

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren added the release-notes:skip If there should be no mention of this in release notes label May 13, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.40%. Comparing base (160077a) to head (99eda26).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7875      +/-   ##
==========================================
+ Coverage   76.08%   85.40%   +9.32%     
==========================================
  Files         381      381              
  Lines       23560    23560              
  Branches      885      886       +1     
==========================================
+ Hits        17926    20122    +2196     
+ Misses       5525     3326    -2199     
- Partials      109      112       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some smaller comments.

######################################

The Manage experiments tool has become nicer to work with. Before you would just get text information about each experiment:
![Screenshot from 2024-04-30 08-49-37](https://github.com/equinor/ert/assets/32731672/5db26f19-e772-4178-85ba-670b35a21e8b)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not render correctly I think?

Comment on lines 58 to 64
Click on the square for the long running realization, 0 in the image:

.. image:: click-on-realization.png

Now click the "OPEN" button in the column STDERR for row ECLIPSE100:

.. image:: click-on-stderr.png

If the message contains "Eclipse failed due to license failure, retrying in XXs" then the license server is busy and we will automatically retry running eclipse in the specified number of seconds.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest merging these two images, as it is hard to tell in the first image where to press, while in the second there is a blue highlight around the realization. Suggest also adding a blue border around STDERR and having some numbers next to where to press.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines 36 to 40
The Manage experiments tool has become nicer to work with. Before you would just get text information about each experiment:
![Screenshot from 2024-04-30 08-49-37](https://github.com/equinor/ert/assets/32731672/5db26f19-e772-4178-85ba-670b35a21e8b)
.. image:: v9_manage_experiments.png

Now there is a separate panel for viewing the information:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest a little rewrite, something along the lines of:

More information has been added to the Experiment manager tool, a new panel has been added with more information about about the experiment and ensembles.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or if you want to embellish:

The interface for the Manage Experiments tool has been improved to provide more information about ensembles and experiments.

A new panel has been introduced, which is dedicated to displaying detailed information for each experiment. This streamlines the process of reviewing and analyzing experiment data.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delicate work! 🎨

@eivindjahren eivindjahren merged commit 72e5ea7 into equinor:main May 21, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create release notes for version 10.0.0
4 participants