Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ee new #7863

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Ee new #7863

wants to merge 2 commits into from

Conversation

xjules
Copy link
Contributor

@xjules xjules commented May 10, 2024

Issue
Rebasing in progress for #6994

Approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@xjules xjules self-assigned this May 10, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.27586% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 85.47%. Comparing base (9b2c566) to head (136ccb0).
Report is 1 commits behind head on main.

Files Patch % Lines
src/ert/ensemble_evaluator/evaluator_async.py 89.64% 26 Missing ⚠️
src/ert/run_models/base_run_model.py 76.66% 7 Missing ⚠️
src/ert/ensemble_evaluator/_builder/_ensemble.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7863      +/-   ##
==========================================
+ Coverage   85.42%   85.47%   +0.05%     
==========================================
  Files         381      382       +1     
  Lines       23536    23824     +288     
  Branches      891      893       +2     
==========================================
+ Hits        20106    20364     +258     
- Misses       3322     3353      +31     
+ Partials      108      107       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Note that EEAsync will be activated when SchedulerFeature is enabled.

A new asyncio.loop is set in base_run_mode to run the entire EEAsync.
This follows a similar pattern to Scheduler; ie. create a set of
background tasks responsible for running the ee server, processing
events, sending snapshots updates, etc.
For the sake of tests that also use the current sync Monitor in
evaluator tracker, the EnsembleEvaluatorAsync will running in a
dedicated ErtThread with the async code.
NB! It does not use BatchingDispatcher.
It does not use wait_for_evaluator as we know when it started
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants