Show delete run-path dialog only for non-empty iter #7860
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7860 +/- ##
=======================================
Coverage 85.38% 85.38%
=======================================
Files 381 381
Lines 23602 23611 +9
Branches 892 883 -9
=======================================
+ Hits 20152 20161 +9
+ Misses 3341 3336 -5
- Partials 109 114 +5 ☔ View full report in Codecov by Sentry. |
dafeda
added
the
release-notes:bug-fix
dafeda
changed the title
| @@ -613,6 +613,15 @@ def check_if_runpath_exists(self) -> bool: | |||
| """ | |||
| return any(Path(run_path).exists() for run_path in self.paths) | |||
|
|
|||
| def check_if_runpath_contains_data(self, iteration: int) -> bool: | |||
| target_folder = f"iter-{iteration}" | |||
There was a problem hiding this comment.
There is no requirement to have iter in the runpath, and for example in prediction runs it is not used, so changing poly.ert to: RUNPATH poly_out/realization-<IENS>/<PRED_DIR> is valid.
There was a problem hiding this comment.
Ah, that makes sense. Need to rethink this then.
| def check_if_runpath_contains_data(self, iteration: int) -> bool: | ||
| target_folder = f"iter-{iteration}" | ||
|
|
||
| for run_path in self.paths: |
There was a problem hiding this comment.
Think perhaps this is the root cause of the problems, self.paths should only return what is actually going to be run in, but suspect there is a bug there.
|
Suggest removing: |
|
Solved by: #7940 |
Resolves: #7633
When applicable