-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace <GEO_ID> in summary config input file name #7626
Replace <GEO_ID> in summary config input file name #7626
Conversation
e65d406
to
f3e7a7b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7626 +/- ##
==========================================
+ Coverage 84.47% 85.19% +0.71%
==========================================
Files 383 383
Lines 23285 23288 +3
Branches 876 893 +17
==========================================
+ Hits 19670 19840 +170
+ Misses 3501 3341 -160
+ Partials 114 107 -7 ☔ View full report in Codecov by Sentry. |
138d322
to
f0a39d7
Compare
237e6ef
to
d98c1f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks reasonable to me, but I would like a second opinion by @oyvindeide as this touches on some internalisation. Also, do we need to backport this?
It is not a critical bug in everest, more like a nice to have than anything else. So I would say it does not need a backport, it can wait to hit users in the next release |
5255970
to
76b8fe2
Compare
76b8fe2
to
0de9c39
Compare
Discussed with @oyvindeide and decided to postpone this feature until we start on Everest refactoring and ert integration. |
Issue
Resolves https://github.com/equinor/everest/issues/2252
Approach
When reading the summary config file if the file name contains <GEO_ID> and the runpath also contains a
geo_realization
folder replace <GEO_ID> with the geo_realization folder number(Screenshot of new behavior in GUI if applicable)
When applicable