Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace <GEO_ID> in summary config input file name #7626

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Apr 10, 2024

Issue
Resolves https://github.com/equinor/everest/issues/2252

Approach
When reading the summary config file if the file name contains <GEO_ID> and the runpath also contains a geo_realization folder replace <GEO_ID> with the geo_realization folder number

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@DanSava DanSava self-assigned this Apr 10, 2024
@DanSava DanSava force-pushed the replace-geo-id-for-summary-config-input-file branch from e65d406 to f3e7a7b Compare April 10, 2024 14:49
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.19%. Comparing base (dbafb2c) to head (d98c1f8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7626      +/-   ##
==========================================
+ Coverage   84.47%   85.19%   +0.71%     
==========================================
  Files         383      383              
  Lines       23285    23288       +3     
  Branches      876      893      +17     
==========================================
+ Hits        19670    19840     +170     
+ Misses       3501     3341     -160     
+ Partials      114      107       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanSava DanSava force-pushed the replace-geo-id-for-summary-config-input-file branch 3 times, most recently from 138d322 to f0a39d7 Compare April 11, 2024 06:37
@DanSava DanSava force-pushed the replace-geo-id-for-summary-config-input-file branch 2 times, most recently from 237e6ef to d98c1f8 Compare April 11, 2024 10:52
@DanSava DanSava requested a review from oyvindeide April 11, 2024 11:25
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks reasonable to me, but I would like a second opinion by @oyvindeide as this touches on some internalisation. Also, do we need to backport this?

@DanSava
Copy link
Contributor Author

DanSava commented Apr 12, 2024

This change looks reasonable to me, but I would like a second opinion by @oyvindeide as this touches on some internalisation. Also, do we need to backport this?

It is not a critical bug in everest, more like a nice to have than anything else. So I would say it does not need a backport, it can wait to hit users in the next release

@DanSava DanSava force-pushed the replace-geo-id-for-summary-config-input-file branch 3 times, most recently from 5255970 to 76b8fe2 Compare April 19, 2024 13:41
@DanSava DanSava force-pushed the replace-geo-id-for-summary-config-input-file branch from 76b8fe2 to 0de9c39 Compare April 22, 2024 13:40
@DanSava
Copy link
Contributor Author

DanSava commented May 29, 2024

Discussed with @oyvindeide and decided to postpone this feature until we start on Everest refactoring and ert integration.

@DanSava DanSava closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants