-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove C Torque driver and tests #7919
Remove C Torque driver and tests #7919
Conversation
1044746
to
bf9839f
Compare
3c15721
to
cbca4d2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7919 +/- ##
==========================================
+ Coverage 85.38% 85.86% +0.48%
==========================================
Files 381 378 -3
Lines 23593 23027 -566
Branches 881 633 -248
==========================================
- Hits 20144 19772 -372
+ Misses 3335 3177 -158
+ Partials 114 78 -36 ☔ View full report in Codecov by Sentry. |
Do we know if some of the test codes deleted here have not (yet?) been ported to the new Scheduler? |
Should there be changes to ert/config/parsing/queue_system.py as well? |
It is used by scheduler too, so I cannot change too much there unless I split it into LegacyQueueSystem and SchedulerQueueSystem. I tried doing this, and it created mypy typing issues. There is probably a better way around this, but I am not sure how much work should be put into it when it is going away regardless. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Before merge, do we need to also disable some Torque testing in komodo-releases/.github/workflows? |
Yes, let's merge this one first: https://github.com/equinor/komodo-releases/pull/5810 |
Issue
Resolves #7912
Approach
✂️
(Screenshot of new behavior in GUI if applicable)
When applicable