New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Argument for creating parameters #279
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One concern is that only four distributions (uniform, exponential log-normal, and normal) are tested in test_parameters.py
, but all distributions seem to be modified with this change. Additionally, it would be good to see a test of how this propgates into estimates of the output moments for a function. I'd be happy to add the needful to test_statistics.py
.
This argument allows the user to create parameters based on
scipy.fit()
method. The user won't be required to input the required arguments for the selected distributions and simply pass the data for which they want to create a parameter object.Syntax:
eq.Parameter(distribution='gaussian',data=arr)
Currently, data parameter is added for:
The required documentation has been added and test cases have been added in
tests/test_parameter.py