Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add txn id on nexo transactions #203

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add txn id on nexo transactions #203

wants to merge 2 commits into from

Conversation

iloveitaly
Copy link
Contributor

No description provided.

eprbell
eprbell requested changes Sep 17, 2023
View reviewed changes
Copy link
Owner

@eprbell eprbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. Also please rebase your code to get past the documentation error.

@iloveitaly
Copy link
Contributor Author

@eprbell done!

@macanudo527
Copy link
Collaborator

@iloveitaly just a heads up. The failing tests are caused by a change in the fiat pricing API we use. A PR has already been opened to address it #212

@macanudo527 macanudo527 mentioned this pull request Oct 20, 2023
Merged
@macanudo527
Copy link
Collaborator

@iloveitaly @eprbell The tests on this pass now with the updated fiat gateway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eprbell eprbell eprbell requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iloveitaly @macanudo527 @eprbell