Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup: permissions #1986

Merged
merged 2 commits into from
Jan 9, 2023
Merged

fixup: permissions #1986

merged 2 commits into from
Jan 9, 2023

Conversation

andreas-kupries
Copy link
Contributor

@andreas-kupries andreas-kupries commented Jan 9, 2023

fix #1955

@andreas-kupries andreas-kupries added the kind/chore Excluded from release notes. Tech dept to be addressed label Jan 9, 2023
@andreas-kupries andreas-kupries self-assigned this Jan 9, 2023
@andreas-kupries
Copy link
Contributor Author

Sigh. ... GH_TOKEN cannot be configured for proper access, ref snok/container-retention-policy#27
Need a PAT.

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2023

Codecov Report

Base: 33.00% // Head: 8.26% // Decreases project coverage by -24.74% ⚠️

Coverage data is based on head (48cc44b) compared to base (71feb23).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #1986       +/-   ##
==========================================
- Coverage   33.00%   8.26%   -24.75%     
==========================================
  Files         179      93       -86     
  Lines       14523   10111     -4412     
==========================================
- Hits         4794     836     -3958     
- Misses       9078    9220      +142     
+ Partials      651      55      -596     
Flag Coverage Δ
acceptance-api ?
acceptance-cli ?
unittests 8.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
main.go 0.00% <0.00%> (-100.00%) ⬇️
internal/services/client.go 0.00% <0.00%> (-86.96%) ⬇️
internal/application/secret.go 0.00% <0.00%> (-80.86%) ⬇️
helpers/string.go 0.00% <0.00%> (-80.00%) ⬇️
internal/auth/certs.go 0.00% <0.00%> (-77.78%) ⬇️
internal/services/catalog.go 0.00% <0.00%> (-74.58%) ⬇️
internal/application/scale.go 0.00% <0.00%> (-70.74%) ⬇️
internal/api/v1/info.go 0.00% <0.00%> (-65.39%) ⬇️
internal/cli/usercmd/service.go 0.00% <0.00%> (-64.94%) ⬇️
internal/api/v1/router.go 36.66% <0.00%> (-63.34%) ⬇️
... and 129 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andreas-kupries
Copy link
Contributor Author

With the (classic) PAT set as secret the new flow works.
See for example https://github.com/epinio/epinio/actions/runs/3875264714/jobs/6607553844
Due to the large amount of images we have accrued the flow will catch up over the coming days, incrementally deleting things up to its limit per run.

@andreas-kupries andreas-kupries marked this pull request as ready for review January 9, 2023 15:38
@andreas-kupries andreas-kupries requested a review from a team as a code owner January 9, 2023 15:38
@andreas-kupries andreas-kupries merged commit 8f17955 into main Jan 9, 2023
@andreas-kupries andreas-kupries deleted the 1955-image-cleanup-2 branch January 9, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Excluded from release notes. Tech dept to be addressed
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Cleanup untagged/commits epinio images
3 participants