Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues #502 and #587- Add additional tests #802

Merged
merged 5 commits into from May 18, 2024
Merged

Conversation

nikosbosse
Copy link
Contributor

@nikosbosse nikosbosse commented Apr 22, 2024

Description

This PR partly addresses #502.

As discussed in #502, this PR adds a few additional tests to score() in tests/testthat/test-score.R.
Addressing #502 raised two new issues (#800, #801). I suggest addressing #801 (done) and then adding more tests as suggested in #502.

This PR closes #587.
As discussed in #587, I went through all exported functions and added additional tests to make sure the output class is exactly what we expect it to be. In some places, I cleaned tests by

  • moving headings around,
  • removing duplicated tests
  • adding small additional tests

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@nikosbosse nikosbosse changed the title Issue #502 - Add additional tests to score() Issues #502 and #587- Add additional tests May 5, 2024
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice looks good to me

@nikosbosse nikosbosse merged commit 39ac584 into main May 18, 2024
9 checks passed
@nikosbosse nikosbosse deleted the add-tests-score branch May 18, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check all calls to `as.data.table() to make sure they are not dropping classes we want to keep
2 participants