Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to "confirmed" cases #505

Open
sbfnk opened this issue Nov 13, 2023 · 2 comments
Open

Remove references to "confirmed" cases #505

sbfnk opened this issue Nov 13, 2023 · 2 comments
Assignees

Comments

@sbfnk
Copy link
Contributor

sbfnk commented Nov 13, 2023

At the moment the main functions in the package expect a data frame with columns date and confirm. Also much of the reporting refers to "confirmed cases". However, the package functionality could be applied to any data streams (e.g. suspect/probable cases, hospitalisations etc.), where "confirmed" cases often refer to a particular subclass that were e.g. lab-tested.

I'd suggest to remove the language around "confirmed" cases and perhaps just to refer to "cases", which leaves the case definition open. Alternatively/additionally we could make it a user argument (perhaps as part of #346) so that plot labels, summaries etc. could reflect whatever the model is being fitted to. The input data frame could then also be expected to have a column of more neutral name (e.g. value) instead of confirm.

@seabbs
Copy link
Contributor

seabbs commented Nov 13, 2023

Agree that we could move to a neutral default value and agree we should ideally allow the user to specify this with something else when inputting data. Also agree we should then keep track of this and use where it is needed.

@sbfnk
Copy link
Contributor Author

sbfnk commented May 1, 2024

Pushing this to a later version to be addressed alongside #346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants