Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godot4: Inkgd seems to try and load any json file in the project #78

Open
asciifaceman opened this issue Dec 27, 2023 · 2 comments
Open

Comments

@asciifaceman
Copy link

asciifaceman commented Dec 27, 2023

Describe the bug
We are using Panku and Inkgd. Panku has some json files in its addon directory, and it appears once inkgd is added it starts trying to load the panku json files

  Error importing 'res://addons/panku_console/modules/interactive_shell/side_menu_config.json'.
  Error importing 'res://addons/panku_console/modules/interactive_shell/side_menu_config.json'.
  Error importing 'res://addons/panku_console/modules/interactive_shell/side_menu_config.json'.
  Error importing 'res://addons/panku_console/modules/interactive_shell/side_menu_config.json'.
  Error importing 'res://addons/panku_console/modules/interactive_shell/side_menu_config.json'.
  Error importing 'res://addons/panku_console/modules/interactive_shell/side_menu_config.json'.
  Error importing 'res://addons/panku_console/modules/interactive_shell/side_menu_config.json'.
  Error importing 'res://addons/panku_console/modules/interactive_shell/side_menu_config.json'.

To Reproduce
Install Panku and Inkgd at the same time

I am curious if it would be worth having a setting that would limit inkgd to only a directory. We, for example, always keep our ink files within one directory structure dedicated to ink stories - it could absolutely recursively load from there while avoiding the rest of the project.

I may make this change to my local copy myself just to stop these errors, but wanted to suggest it for the repo as well

@asciifaceman
Copy link
Author

It seems the default behavior of the json importer plugin is to fail on any json file in the entire project that isn't an ink json. This feels really bad given how much json is used (for game data or other addons like the gut addon used by inkgd itself)

 Error importing 'res://.gutconfig.json'.
 Error importing 'res://.gut_editor_config.json'.

@asciifaceman
Copy link
Author

Ah, I realize now that you can toggle import settings per file to not be an ink story.

I wonder if there is any way for this to not be universally applied to all json files, it could be very cumbersome to turn that off on many json files (say content files, item defs etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant