Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New sphere graph #55

Open
wants to merge 372 commits into
base: master
Choose a base branch
from
Open

New sphere graph #55

wants to merge 372 commits into from

Conversation

Droxef
Copy link

@Droxef Droxef commented Jul 9, 2019

No description provided.

@nperraud nperraud requested review from mdeff and nperraud July 16, 2019 06:06
@nperraud
Copy link
Collaborator

@mdeff I am not sure, we should have healpy as a dependency. It is a big package that takes time to install and we only use it for one function. What do you think?

@mdeff
Copy link
Collaborator

mdeff commented Jul 16, 2019 •
edited

Absolutely. It should be lazily imported (as matplotlib, pyqtgraph, flann, etc.). That is, it's only imported when the user calls the SphereHealpix constructor, not when the pygsp is imported. The only hard dependencies are numpy and scipy. @Droxef did it correctly.

Charles Gallay and others added 26 commits July 25, 2019 13:17
@Droxef
Import all the signals as asked in epfl-lts2#32 (comment)
073cdb9
@Droxef
Simplify from_graphtool()
3f605fb
@Droxef
Cleaner way of adding the signal
2f06053
@Droxef
Test environement on travis
b519b65
@Droxef
Bug fix
531bd11
@Droxef
Add auto selection of save and load backend based on the format
6b53fed 
of the file.
@Droxef
install dependencies for graph-tool on travis
7fde447
@cafeal @Droxef
Fix extract_components
d09bb0a
@Droxef
test for python > 3.5 only
01fc3ef
@Droxef
Fix save for graph_tool (dot, gml)
40c5755
@Droxef
clean code
ff928da
@Droxef
fix verison for test_save_load
e892d0e
@Droxef
use graph_tool.generation to gen random graph
fa369bf
@Droxef
remove useless isomorphic testing
023f4fe
@Droxef
Convert to float the singal when exporting to networkx
605cbb6
@Droxef
skip graph tool tests for python2.7
267e37f
@mdeff @Droxef
Update pygsp/graphs/graph.py
a022f8d 
Accept change

Co-Authored-By: cgallay <charles.gallay@epfl.ch>
@mdeff @Droxef
Update pygsp/graphs/graph.py
f2684e6 
Accept change

Co-Authored-By: cgallay <charles.gallay@epfl.ch>
@mdeff @Droxef
Update pygsp/graphs/graph.py
393d185 
accept change

Co-Authored-By: cgallay <charles.gallay@epfl.ch>
@Droxef
remove support for dot export and import
68f0af2
@Droxef
use graph_tool.spectral.adjacency
957eabe
@mdeff @Droxef
RandomRing: use a kernel
696397e
@mdeff @Droxef
RandomRing: cleanup
fd917d2
@mdeff @Droxef
StochasticBlockModel: allow to indefinitely try to get a connected graph
a10062e
@mdeff @Droxef
test: avoid failed tests due to non connected graphs
1d92574
@mdeff @Droxef
merge all the extra requirements in a single dev requirement
b101d6e
@mdeff mdeff mentioned this pull request Oct 17, 2019
Open
@mdeff mdeff self-assigned this May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdeff mdeff Awaiting requested review from mdeff

@nperraud nperraud Awaiting requested review from nperraud

Assignees

@mdeff mdeff

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Droxef @nperraud @mdeff @cafeal @jbcdnr