[WIP] Refactor polynomial approximations and filtering in general #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is to have multiple TestCase in one module without the need to concatenate them in one suite per module.
Get the plotting updates.
mdeff
force-pushed
the
polynomial-approximations
branch
from
cbb85e1
to
5ca1ae0
Compare
Benchmark on the whole test suite (i.e. make test): * Before: Ran 140 tests in 336.127s * Avoid building LIL and TRIL: Ran 140 tests in 310.229s * Avoid building the CSR if not necessary: Ran 140 tests in 303.354s Benchmark pygsp.graphs.Graph(W) on large graph (800k nodes, 3M edges): * Before: 14.7 s ± 693 ms * After: 207 ms ± 15.4 ms
|
Should we merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
history.rstfor details and motivation. Work in progress, not ready to be merged.