Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1928 - Support monomer to molecule connections type #1948

Merged
merged 5 commits into from
May 16, 2024
Merged

#1928 - Support monomer to molecule connections type #1948

merged 5 commits into from
May 16, 2024

Conversation

even1024
Copy link
Collaborator

@even1024 even1024 commented May 14, 2024 •
edited

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

@even1024 even1024 linked an issue May 14, 2024 that may be closed by this pull request
Support monomer to molecule connections type #1928
Closed
AliaksandrDziarkach
AliaksandrDziarkach approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@AliaksandrDziarkach AliaksandrDziarkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@even1024 even1024 merged commit 57f03c8 into master May 16, 2024
74 checks passed
@even1024 even1024 deleted the 1928-mol-monomer branch May 16, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliaksandrDziarkach AliaksandrDziarkach AliaksandrDziarkach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support monomer to molecule connections type
2 participants
@even1024 @AliaksandrDziarkach