Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support monomer to molecule connections type #1928

Closed
rrodionov91 opened this issue Apr 24, 2024 · 1 comment · Fixed by #1948
Closed

Support monomer to molecule connections type #1928

rrodionov91 opened this issue Apr 24, 2024 · 1 comment · Fixed by #1948
Assignees
Labels

Comments

@rrodionov91
Copy link
Collaborator

Background
Currently connections between monomers and molecules are not supported.

Solution
It needs to support it for ket and mol v3000 formats.

Proposed changes for ket:

// Connection
{
    "connectionType": "single",
    "endpoint1": {
        "monomerId": "monomer14",
        "attachmentPointId": "R3"
    },
    "endpoint2": {
        "moleculeId": "mol1",
        "atomId": "2"
    }
},
@rrodionov91 rrodionov91 changed the title Support monomer to molecule connection type Support monomer to molecule connections Apr 24, 2024
@rrodionov91 rrodionov91 changed the title Support monomer to molecule connections Support monomer to molecule connections type Apr 24, 2024
@rrodionov91 rrodionov91 added this to the Indigo-1.21.0-rc.1 milestone Apr 25, 2024
@even1024 even1024 self-assigned this May 2, 2024
@even1024 even1024 linked a pull request May 14, 2024 that will close this issue
7 tasks
@AlexeyGirin AlexeyGirin self-assigned this May 31, 2024
@AlexeyGirin
Copy link
Collaborator

Verified.
image

  • Indigo Toolkit Version 1.21.0-rc.1.0-g9194599b2-wasm32-wasm-clang-19.0.0
  • Ketcher Version 2.22.0-rc.2 Build at 2024-06-03; 18:43:00
  • Chrome Version 125.0.6422.142 (Official Build) (64-bit)
  • Windows 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants