Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CICD build to use Leap v5 #140

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

ericpassmore
Copy link
Contributor

Currently set to use Leap v3, need to update CICD to Leap v5. Fixes #139

Copy link
Member

@spoonincode spoonincode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest upgrading the build to ubuntu22 at the same time. on ubuntu20, libtester 5.0 is built with gcc10 where as eos-system-contracts CI will still use gcc9 as currently configured. This will one day cause grief (it's why libtester on ubuntu20 isn't tested any longer in leap repo), and regardless of grief is probably a ODR violation like this too.

Alternatively we could change the current ubuntu20 workflow to use gcc10 just like libtester. But it's more forward looking (and cleaner imo) to just upgrade to ubuntu22.

You will need to change at least


file: 'leap-dev.*(x86_64|amd64).deb'

artifact-name: leap-dev-ubuntu20-amd64

@ericpassmore
Copy link
Contributor Author

I would suggest upgrading the build to ubuntu22 at the same time. on ubuntu20, libtester 5.0 is built with gcc10 where as eos-system-contracts CI will still use gcc9 as currently configured. This will one day cause grief (it's why libtester on ubuntu20 isn't tested any longer in leap repo), and regardless of grief is probably a ODR violation like this too.

Alternatively we could change the current ubuntu20 workflow to use gcc10 just like libtester. But it's more forward looking (and cleaner imo) to just upgrade to ubuntu22.

You will need to change at least

file: 'leap-dev.*(x86_64|amd64).deb'

artifact-name: leap-dev-ubuntu20-amd64

No problem, we can make those changes. Can we upgrade to v4 build actions as well? This would pull in changes from PR #109

@ericpassmore ericpassmore merged commit 0e73ed5 into main May 15, 2024
1 check passed
@ericpassmore ericpassmore deleted the ehp/gh-139-cicd-leap-v5 branch May 15, 2024 19:11
@ericpassmore
Copy link
Contributor Author

Note:start
group: RELEASE
category: CHORE
summary: Update build actions to latest and move to ubuntu 22.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CICD Leap Build to v5 Update build actions from reference-contracts
3 participants