Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nonleptonic amplitudes for B -> PP phenomenology #846

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Nonleptonic amplitudes for B -> PP phenomenology #846

wants to merge 8 commits into from

Conversation

mreboud
Copy link
Contributor

@mreboud mreboud commented May 3, 2024 •
edited

TODO:

  • Complete the tests
  • Implement the remaining physical observables

@mreboud mreboud added enhancement Feature request physics Issue with the physics predictions labels May 3, 2024
@mreboud mreboud added this to the Release 1.1 milestone May 3, 2024
@mreboud mreboud requested review from dvandyk and a team May 3, 2024 14:19
MJKirk
MJKirk reviewed May 7, 2024
View reviewed changes
eos/b-decays/observables.cc Outdated Show resolved Hide resolved
eos/references.yaml Outdated Show resolved Hide resolved
@mreboud mreboud force-pushed the b-to-hh branch 3 times, most recently from 79199e9 to e460fd5 Compare May 17, 2024 08:27
@mreboud mreboud marked this pull request as ready for review May 17, 2024 08:28
dvandyk
dvandyk reviewed May 17, 2024
View reviewed changes
Copy link
Member

@dvandyk dvandyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some comments.

eos/parameters/hadron-properties.yaml Show resolved Hide resolved
eos/parameters/hadron-properties.yaml Outdated Show resolved Hide resolved
eos/parameters/hadron-properties.yaml Outdated Show resolved Hide resolved
eos/utils/options.cc Outdated Show resolved Hide resolved
eos/utils/qualified-name.cc Show resolved Hide resolved
eos/nonleptonic-amplitudes/su3-amplitudes.hh Outdated Show resolved Hide resolved
eos/nonleptonic-amplitudes/su3-amplitudes.hh Outdated Show resolved Hide resolved
eos/nonleptonic-amplitudes/su3-amplitudes.hh Outdated Show resolved Hide resolved
eos/nonleptonic-amplitudes/topological-amplitudes.cc Outdated Show resolved Hide resolved
eos/b-decays/b-to-psd-psd.cc Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MJKirk MJKirk MJKirk left review comments

@dvandyk dvandyk dvandyk approved these changes

Assignees

@mreboud mreboud

@martabm99 martabm99

Labels
enhancement Feature request physics Issue with the physics predictions
Projects
None yet
Milestone
Release 1.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mreboud @dvandyk @MJKirk @martabm99