Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in ShallowWrapper and ReactWrapper docs: MyCStatefullass -> Stateful #2602

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

josephfrazier
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3a7701c) 96.42% compared to head (ad48340) 96.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2602   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files          49       49           
  Lines        4332     4334    +2     
  Branches     1156     1156           
=======================================
+ Hits         4177     4179    +2     
  Misses        155      155           

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, find/replace strikes again

@josephfrazier
Copy link
Author

heh, I see it's in ReactWrapper too:

expect(instance).to.be.instanceOf(MyCStatefullass);

Want me to fix that here, or in another PR, or will you take care of it?

@ljharb
Copy link
Member

ljharb commented Oct 11, 2023

In the same PR, please :-) i'll get it if you don't, but please feel free to cover it in the meantime

@josephfrazier josephfrazier changed the title Fix typo in ShallowWrapper docs: MyCStatefullass -> Stateful Fix typo in ShallowWrapper and ReactWrapper docs: MyCStatefullass -> Stateful Oct 11, 2023
@josephfrazier
Copy link
Author

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants