Skip to content
This repository has been archived by the owner on Jul 7, 2019. It is now read-only.

EnyimMemcached with touch support #147

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

mahirsertkaya
Copy link

Touch support required for extending items' TTL value

enyim and others added 6 commits November 5, 2014 02:42
Expirations specified in DateTime or TimeSpans > 30 days will use absolute expirations.
Touch support required for extending items' TTL value
@mahirsertkaya mahirsertkaya reopened this Jan 6, 2016
@mahirsertkaya
Copy link
Author

Hi, I am using this great library for many years, thanks to you.

I needed an touch operation lately.

In Touch&Gat implementation checkin (enyim committed on Mar 29, 2011), you implemented this method but somehow it is not available in master any more because is no Membase/MembaseClient.cs file.

I hope if it is also works for you, check this commit out please

@javimaravillas
Copy link

Hi,
It looks really cool and it would be amazing if this commit is merged to master :)

Regards,

@enyim
Copy link
Owner

enyim commented Jan 27, 2016

Hi,

Apologies for getting to this PR so late. On first sight this looks OK, but before merging it, can you please fix the following minor issues:

  • use the same formatting as the rest of the code-base (tab indented, all other C# styles must be default Visual Studio styles)
  • provide tests for the operations
  • do not commit the packages folder
  • do not upgrade packages, unless it's absolutely neccessary

Thanks!

@mahirsertkaya
Copy link
Author

Hi i will consider and fix these issues asap

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants