New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few more keyword argument issues #668

Open

quantum5 wants to merge 1 commit into envygeeks:master from quantum5:kwarg-fix

quantum5 commented Sep 7, 2023

I have added or updated the specs/tests.
I have verified that the specs/tests pass on my computer.
I have not attempted to bump, or alter versions.
This is a documentation change.
This is a source change.

Description

This PR fixes several more keyword argument issues after #666. Both this PR and #666 should be merged in conjunction.

quantum5 requested a review from envygeeks as a code owner

September 7, 2023 07:05

quantum5 force-pushed the kwarg-fix branch from c58f94d to 3653b13 Compare

September 7, 2023 07:51

tdooner mentioned this pull request

Upgrade ruby 2.7 -> 3.2, jekyll 3.8.7 -> 4.3.2 caciviclab/odca-jekyll#460

Closed


          Fix a few more keyword argument issues

62a84eb

quantum5 force-pushed the kwarg-fix branch from 3653b13 to 62a84eb Compare

October 7, 2023 01:46

willkoehler added a commit to willkoehler/my_blog that referenced this pull request


          Lock Ruby to v2.7.8

Trying to get this blog running on Ruby 3.x led to a whole series of problems with old gems that are no longer being maintained.

See https://stackoverflow.com/a/72906202/935514
See envygeeks/jekyll-assets#666
See envygeeks/jekyll-assets#668
See Shopify/liquid#1625

bravecrayon mentioned this pull request

Fix wrong number of arguments in proxy.rb and writer.rb #666

Open

4 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment