[balsa] Add tests to document behavior when header value contains CR or LF. #34088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re(). Signed-off-by: Bence Béky <bnc@google.com>
These characters are invalid according to RFC9110 Section 5.5 [1]. Either the message must be rejected, or the characters replaced by SP according to the RFC. These tests confirm that both http-parser and BalsaParser indeed either reject the message or remove the forbidden characters, though neither of them seem to insert a SP in their place. [1] https://www.rfc-editor.org/rfc/rfc9110.html#name-field-values Signed-off-by: Bence Béky <bnc@google.com>
Signed-off-by: Bence Béky <bnc@google.com>
|
/assign @yanavlasov |
yanavlasov
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These characters are invalid according to RFC9110 Section 5.5 [1].
Either the message must be rejected, or the characters replaced by SP
according to the RFC. These tests confirm that both http-parser and
BalsaParser indeed either reject the message or remove the forbidden
characters, though neither of them seem to insert a SP in their place.
Balsa implementation tracking issue: #21245
[1] https://www.rfc-editor.org/rfc/rfc9110.html#name-field-values
Commit Message: Add tests to document behavior when header value contains CR or LF.
Additional Description:
Risk Level: low, test-only change
Testing: test/common/http/http1:codec_impl_test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a