Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for upstream http filters in tcp tunneling case #34085

Merged

Conversation

vikaschoudhary16
Copy link
Contributor

followup to #32991
Commit Message: Add integration test for upstream http filters in tcp tunneling case

Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Vikas Choudhary <choudharyvikas16@gmail.com>
@vikaschoudhary16
Copy link
Contributor Author

ping @alyssawilk

Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for a first test
we're going to want to make sure filter pausing and resumption works (backs up data, resumes with correct payload), local replies and stream resets work, etc etc.
Happy to land this as incremental improvement though!

@alyssawilk alyssawilk merged commit c9fb521 into envoyproxy:main May 13, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants