dfp: cleanup and cache feature #34068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
requested review from
RyanTheOptimist,
abeyad,
fredyw and
mattklein123
as code owners
abeyad
reviewed
May 13, 2024
abeyad
approved these changes
May 13, 2024
| runRemoveCallbacks(host); | ||
| } | ||
| { | ||
| removeCacheEntry(host); |
There was a problem hiding this comment.
Out of curiosity, can this be moved outside of the scoped block (which seems to be for the writer_lock)?
There was a problem hiding this comment.
good call - I was just copying what was done above.
| // If we need to erase the host, hold onto the PrimaryHostInfo object that owns this callback. | ||
| // This is defined at function scope so that it is only erased on function exit to avoid | ||
| // use-after-free issues | ||
| PrimaryHostInfoPtr host_to_erase; |
There was a problem hiding this comment.
Up to you but I would be inclined to move this down closer to where it's used (just before the opening of the scoped block).
There was a problem hiding this comment.
as these are optional comments, will do in a follow-up. next PR in this space :-)
RyanTheOptimist
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]