tls: splitting config into downstream and upstream #34066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
commented
May 9, 2024
| alwayslink = True, | ||
| ) | ||
|
|
||
| envoy_cc_extension( |
There was a problem hiding this comment.
I'm intentionally leaving a config library which includes both because for legacy servers we always had them under one extension, and there's a lot of build target churn otherwise. I can do the churn if you think it's worth it
| @@ -6,7 +6,6 @@ load("@envoy_build_config//:extensions_build_config.bzl", "EXTENSIONS") | |||
| _required_extensions = { | |||
| "envoy.http.original_ip_detection.xff": "//source/extensions/http/original_ip_detection/xff:config", | |||
| "envoy.request_id.uuid": "//source/extensions/request_id/uuid:config", | |||
There was a problem hiding this comment.
removing here is balanced out by adding to the exe explicitly.
I think it's more consistent to do that for required extensions, especially as we believe the openssl buid is stale
alyssawilk
requested review from
RyanTheOptimist,
abeyad,
fredyw,
lizan and
ggreenway
as code owners
|
/retest |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
Ok this is now passing CI, sorry for noise |
ggreenway
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]