Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discovery: removing some exceptions #34053

Merged
merged 1 commit into from May 13, 2024
Merged

discovery: removing some exceptions #34053

merged 1 commit into from May 13, 2024
+39 −35

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented May 9, 2024 •
edited

Risk Level: low
Testing: updated tests
Docs Changes: n/a
Release Notes: n/a
envoyproxy/envoy-mobile#176

@repokitteh-read-only RepoKitteh - Read Only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #34053 was opened by alyssawilk.

see: more, trace.

@alyssawilk
discovery: removing some exceptions
23b08ee 
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk alyssawilk marked this pull request as ready for review May 9, 2024 20:31
@alyssawilk alyssawilk enabled auto-merge (squash) May 9, 2024 20:31
@alyssawilk alyssawilk merged commit 25af3dd into envoyproxy:main May 13, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanavlasov yanavlasov yanavlasov approved these changes

Assignees

@yanavlasov yanavlasov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alyssawilk @yanavlasov