Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Mac M1/2 build breakage, by requiring: swig<4. #1068

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

capn-freako
Copy link

I found that the new swig (v4) was causing the same kiva build failure, as I reported in #1067.
So, I:

  1. constrained swig to: "<4", in the pyproject.toml file, and
  2. bumped the minor version number.

@capn-freako
Copy link
Author

Hi @corranwebster ,

Any chance we can get this simple one merged and a rebuild posted to PyPi?
I just released a new package, which is dependent upon Enable, and this is blocking the build/installation.

Thanks!
-db
:)

@capn-freako
Copy link
Author

Hi @cournape @rkern @EdwinWiseOne @sergey-miryanov @corranwebster ,

Could someone just give me a ping, so I know this didn't get lost in the Ether?

Thanks!
-db

Copy link
Member

@jwiggins jwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK merging this without the setup.py change.

setup.py Outdated Show resolved Hide resolved
@capn-freako
Copy link
Author

Hi @jwiggins ,

Any idea when we'll see the updated build show up on PyPi?

Thanks,
-db

Copy link
Member

@jwiggins jwiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@capn-freako
Copy link
Author

Hi @jwiggins ,

Thanks for approving this PR!

I noticed that 3 of the CI/CD jobs are failing w/:

ModuleNotFoundError: No module named 'numpy'

What's going on there?

Thanks,
-db

@jwiggins
Copy link
Member

jwiggins commented Jun 3, 2024

Installing celiagg via pip is failing, so the all the "Test with pip" jobs will currently fail.

@capn-freako
Copy link
Author

capn-freako commented Jun 3, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants