Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Amazon Associates regex #102

Merged
merged 3 commits into from May 13, 2024
Merged

Fix Amazon Associates regex #102

merged 3 commits into from May 13, 2024

Conversation

AlexMili
Copy link
Contributor

Hello,

The Amazon Associates regex doesn't take into account amazon links beginning with www., other TLDs and when the tag query param is at the first place.

Here are some example of URLs not working:

https://www.amazon.com?tag=something
https://amazon.fr?tag=something
https://www.amazon.es?arg=thing&tag=something

kingthorin
kingthorin reviewed May 9, 2024
View reviewed changes
src/technologies/a.json Outdated Show resolved Hide resolved
kingthorin
kingthorin approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@enthec-opensource enthec-opensource merged commit 4d761eb into enthec:main May 13, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingthorin kingthorin kingthorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlexMili @kingthorin @enthec-opensource