Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: insufficient label checks for validity + compare tweaks #85

Merged
merged 6 commits into from Feb 13, 2024

Conversation

TateB
Copy link

@TateB TateB commented Dec 11, 2023

changes:

  • added checkValidLabel calls for labels fetched via ens.nameByHash
    • i was previously under the impression that the rainbow table didn't have labels with ./[/], but it does
  • removed all === for ==, and !== for !=
    • strict equality is compiled differently in older assemblyscript versions (being a comparison of memory pointer rather than data). not sure why graph-ts/graph-cli don't use newer versions yet (using 2+ year old v0.19.10), in newer versions this is fixed.
  • replaced type definition for isNullable so typescript lint doesn't get annoyed by the lack of type narrowing
  • resolvers are now always checked for their existence in ResolverEvent handlers to ensure a non-nullable value isn't null

@TateB TateB merged commit 17294f5 into master Feb 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants