Delegatable resolver #288
Open
Delegatable resolver #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makoto
changed the title
Arachnid
requested changes
Oct 30, 2023
|
PTAL @Arachnid |
jefflau
reviewed
Nov 1, 2023
|
Is this PR now obsolete? |
No, it is not osbolute. #289 is to merge the branch into this branch |
* Use Factory * Add description and more tests * Add check to prevent people from using the resolver without owner * Apply suggestions from code review Co-authored-by: Nick Johnson <arachnid@notdot.net> Co-authored-by: Jeff Lau <tyranel@hotmail.com> * Fix broken tests * Remove owner check --------- Co-authored-by: Nick Johnson <arachnid@notdot.net> Co-authored-by: Jeff Lau <tyranel@hotmail.com>
Arachnid
approved these changes
Nov 1, 2023
|
So, we should use this branch? |
…tory Use addressOfClone2 instead of predictAddress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Delegatable Reolver allows the resolver owner to add an operator to update records of a node on behalf of the owner.
It is going to be created by a factory contract every time a user set up a resolver on L2. The owner can grant operator to any names including subnames.