Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: farcaster account in profile #703

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

TateB
Copy link
Collaborator

@TateB TateB commented Apr 5, 2024

changes:

  • added support for loading eth.farcaster key as farcaster account (with fname/ens)
  • added eth.farcaster validation to validateAccount()
    • follows farcaster hub implementation of name validation: eth name validation reference / fname validation reference
    • accepts fname or ens name
    • only .eth 2LD ens names are compatible
    • rules:
      • only alphanumeric + hyphen
      • cannot start with hyphen
      • lowercase
      • fnames can have length of 1-16 chars
      • .eth 2LD labels can have length of 3-16 chars (3 char min because of registrar restriction)
  • added social data value for eth.farcaster
  • added eth.farcaster to default profile fetch
  • alphabetised all social record lists/objects
  • fixed incorrect address record formats in translations (eth, bnb, ltc)
  • fixed incorrect bnb record format in translation
  • fixed return type of validateCryptoAddress (was any)

@TateB TateB requested a review from sugh01 as a code owner April 5, 2024 02:39
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Deploying ens-app-v3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1c1622d
Status: ✅  Deploy successful!
Preview URL: https://d7555f2c.ens-app-v3.pages.dev
Branch Preview URL: https://feat-farcaster-account.ens-app-v3.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants