fix offchain dns nametype + [root] validation #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying ens-app-v3 with
|
| Latest commit: |
77e67f1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7583d003.ens-app-v3.pages.dev |
| Branch Preview URL: | https://fix-offchain-dns-sync-manage.ens-app-v3.pages.dev |
LeonmanRolls
approved these changes
Mar 29, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User reported a bug where "sync manager" button appeared on his off-chain dns name. The source of the bug was that he also began the process of on-chain import by setting his dns-owner record.
Additional fix in this PR fixes the profile page for [root] where the invalid name warning and isNonASCII warning were showing.
This PR: