Canonical name resolver #161
Draft
+51
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arachnid
requested changes
Sep 25, 2023
|
|
||
| ### Specification | ||
|
|
||
| If a cname is found on a name, all records that are unset will be expected to proxy through the specified cname's records. Records that are already set on the resolver will ignore the cname. |
There was a problem hiding this comment.
This should clarify that it's the resolver's reponsibility to implement CNAME functionality, not the client.
| ```solidity | ||
| interface ICnameResolver { | ||
| event CNameChanged(bytes32 indexed node, string name); | ||
| function cname(bytes32 node) external view returns (string memory); |
There was a problem hiding this comment.
I think we need to make a decision here: Either cname takes a node and doesn't implement CCIP-Read and wildcards (so only onchain names can be CNAMEd to), or it takes a DNS-encoded name and does implement CCIP-Read and wildcards. The latter is the more future-proof option, but this implementation requirement needs to be called out.
| function addr(bytes32 node, uint256 coinType){ | ||
| bytes memory currentAddr = versionable_addresses[recordVersions[node]][node][coinType]; | ||
|
|
||
| if(currentAddr.length == 0 && cname.length != 0){ |
There was a problem hiding this comment.
This will have to be a lot more complex to support CCIP Read and wildcards.
Perhaps we should just implement a canonical CNAME resolver mixin instead of writing a spec?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a standard for a resolver that allows DNS CNAME-like functionality to resolvers.