Evm reverse resolution #157

jefflau · 2023-08-24T08:08:27Z

Renamed the branch so it isn't ensip-16. Old comments/PR here: #132

…-compatible chains

moldy530 · 2023-10-10T20:36:45Z

ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md

+### Resolving Primary ENS Names by a dapp
+
+* If a dapp has a connected user it SHOULD first check the chainId of the user
+* If the chainId is not 1, it SHOULD then construct the ENS name [address].[evmChainCoinType].reverse to obtain the primary ENS name of the user. If none is found, it SHOULD assume that the user has no primary ENS name set


this is cool and kinda what I had in mind but I like the proposal of having L2 registrars in the mix, still grokking but 👍

Appreciate any and all feedback!

ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md

makoto · 2024-02-05T17:19:25Z

ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md

+1) Sign a message to set a default record
+2) call `setName()` on the default registrar on L1
+
+Possibility: Allowing L1 Primary ENS names to also use `default.addr`. This could be incorporated into the public resolver's `name()` function.


Should this be default.reverse ?

Arachnid

You should probably explicitly include the directions from ENSIP 11 here on how to create a coin type from a chain ID.

Perhaps we should have some syntax for this? Most primary names are going to be for chains that have chain IDs as coin types, and it seems weird that they would all have hugely long decimal identifiers instead of the shorter ones a chain ID would offer. The extended DNS resolver uses the syntax e<chain id> as a shorthand; perhaps we can do something like that here too?

ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md

cloudflare-pages · 2024-03-20T15:24:25Z

Deploying ens-docs with Cloudflare Pages

Latest commit:	`8fa5b3c`
Status:	🚫 Build failed.

View logs

ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md

Arachnid · 2024-03-25T15:44:44Z

ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md

+
+To determine the avatar URI for a specific EVM chain address, the client MUST reverse-resolve the address by querying the ENS registry on Ethereum for the resolver of `<address>.<coinType>.reverse`, where `<address>` is the lowercase hex-encoded Ethereum address, without leading '0x'. Then, the client calls `.text(namehash('<address>.<coinType>.reverse'), 'avatar')` to retrieve the avatar URI for the address.
+
+If a resolver is returned for the reverse record, but calling `text` causes a revert or returns an empty string, the client MUST call `.name(namehash('<address>.<coinType>.reverse'))`. If this method returns a valid ENS name, the client MUST:


The way this is worded is overly specific, and implies a method that won't work for a default reverse resolver.

Yeah actually this doesn't really make sense, because there are no custom resolvers on L2 reverse registrars anyway

Also, the examples should be written descriptively - describing what the client does in the example scenario. SHOULd and MUST etc are for the specification itself.

ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md

Co-authored-by: Nick Johnson <arachnid@notdot.net>

Arachnid

This also needs updating to reflect the decision to hex-encode chain IDs.

ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md

Arachnid · 2024-04-04T07:50:49Z

ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md

+
+To determine the avatar URI for a specific EVM chain address, the client MUST reverse-resolve the address by querying the ENS registry on Ethereum for the resolver of `<address>.<coinType>.reverse`, where `<address>` is the lowercase hex-encoded Ethereum address, without leading '0x'. Then, the client calls `.text(namehash('<address>.<coinType>.reverse'), 'avatar')` to retrieve the avatar URI for the address.
+
+If a resolver is returned for the reverse record, but calling `text` causes a revert or returns an empty string, the client MUST call `.name(namehash('<address>.<coinType>.reverse'))`. If this method returns a valid ENS name, the client MUST:


Also, the examples should be written descriptively - describing what the client does in the example scenario. SHOULd and MUST etc are for the specification itself.

…into evm-reverse-resolution

ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md

Co-authored-by: tate <tate@ens.domains>

…nto evm-reverse-resolution

Arachnid · 2024-05-14T09:22:03Z

ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md

+### Resolving Primary ENS Names by a dapp
+
+1) If a dapp has a connected user it SHOULD first check the chainId of the user.
+2) It MUST then construct the cointype using ENSIP11: `coinType = 0x80000000 | chainId`, which must be converted to the hexadecimal representation.


Suggested change

2) It MUST then construct the cointype using ENSIP11: `coinType = 0x80000000 | chainId`, which must be converted to the hexadecimal representation.

2) It MUST then construct the cointype using ENSIP11: `coinType = 0x80000000 | chainId`, which must be converted to lower-case hexadecimal representation.

Arachnid · 2024-05-14T09:22:52Z

ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md

+
+### Resolving Primary ENS Names by a dapp
+
+1) If a dapp has a connected user it SHOULD first check the chainId of the user.


I'm not sure the use of SHOULD and MUST is appropriate here. It's describing an algorithm, and the client doesn't really have any choice about which bits of the algorithm it does; if it doesn't do all of them as-written, it won't work.

Arachnid · 2024-05-14T09:23:30Z

ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md

+
+1) If a dapp has a connected user it SHOULD first check the chainId of the user.
+2) It MUST then construct the cointype using ENSIP11: `coinType = 0x80000000 | chainId`, which must be converted to the hexadecimal representation.
+3) If the chainId is not 1, it SHOULD then construct the ENS node representing the reverse node on that network using the coinType and the user's connected `address`: `node = namehash([address].[coinTypeAsHex].reverse)`


What if the chainId is 1?

Arachnid · 2024-05-14T09:25:23Z

ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md

+10) If a string is found, skip to step 12
+11) If `name` is an empty string, the dapp MUST assume that a primary name does not exist and instead show the address instead. The name resolution process ends here.
+12) If the dapp finds an ENS name, it MUST first check the forward resolution. This can be done by constructing the ENS node for the primary name found: `primaryName = namehash(name)`
+13) It MUST then call the registry to retrieve the resolver `registry.resolver(primaryName)`


This implies not using ENSIP-11 wildcard resolution. Instead, this should just specify that it's to use the resolution process documented there.

Arachnid · 2024-05-14T09:26:01Z

ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md

+11) If `name` is an empty string, the dapp MUST assume that a primary name does not exist and instead show the address instead. The name resolution process ends here.
+12) If the dapp finds an ENS name, it MUST first check the forward resolution. This can be done by constructing the ENS node for the primary name found: `primaryName = namehash(name)`
+13) It MUST then call the registry to retrieve the resolver `registry.resolver(primaryName)`
+14) Once it has the resolver it MUST call the addr function with the appropriate coinType. If a name was found on step 6, it must use the `coinType` from the chainId of the user. If a name was found at step 9, which is the default Primary name for EoAs, it must check the coinType of chainId 0, which represents [an EoA across all EVM chains](https://namespaces.chainagnostic.org/eip155/caip10). `resolvedAddress = resolver.addr(coinType)`


Worth specifying if the legacy addr function could/should be used for chainid 1.

Arachnid · 2024-05-14T09:26:57Z

ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md

+
+### Examples of valid L2 reverse resolution
+
+* Arbitrum: 0F32b753aFc8ABad9Ca6fE589F707755f4df2353.2147525809.reverse


These examples still have decimal cointypes.

Arachnid · 2024-05-14T09:27:25Z

ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md

+
+To make things explicit we will require the signing of a message to confirm that the address in question would like to use mainnet or another network as fallback. This would either resolve directly on mainnet. Defaults would only be applicable to EoAs that can sign a message. This is because smart contract accounts would not be able to reliably set a default on all chains.
+
+### Setting default


This is quite vague. Is it worth including at all?

Arachnid · 2024-05-14T09:28:00Z

ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md

+1) Sign a message to set a default record
+2) call `setName()` on the default registrar on L1
+
+Possibility: Allowing L1 Primary ENS names to also use `default.reverse`. This could be incorporated into the public resolver's `name()` function.


jefflau and others added 8 commits March 14, 2023 15:37

First draft of evm-chain reverse resolution

2739178

Expand upon the spec

6a043e0

Add a point about keeping a default resolver

7abd935

Add line about DAO/multisig owning the subnames controlling ccip-read

53b4a1c

Add extension to ENSIP-12 for avatar resolution

0a6fb2d

Add in reasoning for deprecating use of mainnet reverse record on evm…

bd38f8b

…-compatible chains

Merge branch 'master' of github.com:ensdomains/docs into ensip-16

45d2cbd

Change ensip number to 17

d3a0c48

moldy530 reviewed Oct 10, 2023

View reviewed changes

ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md Outdated Show resolved Hide resolved

Add a default setup process

5341063

lucemans added ENSIP v1 labels Jan 24, 2024

makoto reviewed Feb 5, 2024

View reviewed changes

Fix typo

f71d920

Arachnid reviewed Mar 7, 2024

View reviewed changes

Updates from feedback

1b13e44

jefflau added 6 commits March 20, 2024 15:35

Add link to avatar resolution ensip in evm example

00d9d74

Add link to avatar resolution ensip in evm example

2f35f9b

Update to use evm chain id vs cointype

f184b0b

Add examples of L2 reverse resolution

ec8da79

Resolve conflict

57b220c

resolve conflict

95d8bc9

Arachnid requested changes Mar 25, 2024

View reviewed changes

jefflau and others added 3 commits March 28, 2024 14:26

Update ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md

41b35c1

Co-authored-by: Nick Johnson <arachnid@notdot.net>

Update ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md

acbe22e

Co-authored-by: Nick Johnson <arachnid@notdot.net>

Update ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md

89c4259

Co-authored-by: Nick Johnson <arachnid@notdot.net>

Arachnid reviewed Apr 4, 2024

View reviewed changes

additions from feedback

b478b82

jefflau added 2 commits May 2, 2024 12:00

tMerge branch 'evm-reverse-resolution' of github.com:ensdomains/docs …

95343d4

…into evm-reverse-resolution

Create more detail for the new L2 reverse resolution process

c0ad9cb

TateB reviewed May 6, 2024

View reviewed changes

ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md Outdated Show resolved Hide resolved

jefflau and others added 3 commits May 6, 2024 14:58

Update ens-improvement-proposals/ensip-17-evmchain-reverse-resolution.md

d51d156

Co-authored-by: tate <tate@ens.domains>

Adjust vocabulary to be EVM rather than L2

4609d17

Merge branch 'evm-reverse-resolution' of github.com:ensdomains/docs i…

8fa5b3c

…nto evm-reverse-resolution

jefflau requested review from Arachnid and makoto May 10, 2024 09:35

Arachnid requested changes May 14, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Evm reverse resolution #157

Evm reverse resolution #157

jefflau commented Aug 24, 2023

moldy530 Oct 10, 2023

jefflau Oct 11, 2023

makoto Feb 5, 2024

Arachnid left a comment

cloudflare-pages bot commented Mar 20, 2024 •

edited

Arachnid Mar 25, 2024

jefflau Mar 28, 2024

Arachnid Apr 4, 2024

Arachnid left a comment

Arachnid Apr 4, 2024

Arachnid May 14, 2024

Arachnid May 14, 2024

Arachnid May 14, 2024

Arachnid May 14, 2024

Arachnid May 14, 2024

Arachnid May 14, 2024

Arachnid May 14, 2024

Arachnid May 14, 2024


		To determine the avatar URI for a specific EVM chain address, the client MUST reverse-resolve the address by querying the ENS registry on Ethereum for the resolver of `<address>.<coinType>.reverse`, where `<address>` is the lowercase hex-encoded Ethereum address, without leading '0x'. Then, the client calls `.text(namehash('<address>.<coinType>.reverse'), 'avatar')` to retrieve the avatar URI for the address.

		If a resolver is returned for the reverse record, but calling `text` causes a revert or returns an empty string, the client MUST call `.name(namehash('<address>.<coinType>.reverse'))`. If this method returns a valid ENS name, the client MUST:

	2) It MUST then construct the cointype using ENSIP11: `coinType = 0x80000000 \| chainId`, which must be converted to the hexadecimal representation.
	2) It MUST then construct the cointype using ENSIP11: `coinType = 0x80000000 \| chainId`, which must be converted to lower-case hexadecimal representation.


		### Resolving Primary ENS Names by a dapp

		1) If a dapp has a connected user it SHOULD first check the chainId of the user.


		### Examples of valid L2 reverse resolution

		* Arbitrum: 0F32b753aFc8ABad9Ca6fE589F707755f4df2353.2147525809.reverse


		To make things explicit we will require the signing of a message to confirm that the address in question would like to use mainnet or another network as fallback. This would either resolve directly on mainnet. Defaults would only be applicable to EoAs that can sign a message. This is because smart contract accounts would not be able to reliably set a default on all chains.

		### Setting default

Evm reverse resolution #157

Are you sure you want to change the base?

Evm reverse resolution #157

Conversation

jefflau commented Aug 24, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Arachnid left a comment

Choose a reason for hiding this comment

cloudflare-pages bot commented Mar 20, 2024 • edited

Deploying ens-docs with Cloudflare Pages

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Arachnid left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cloudflare-pages bot commented Mar 20, 2024 •

edited