Create ternary-operator.md #1011
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rule insight:slug failed for files:
|
|
Rule insight:slug failed for files:
|
|
@Stefan-Stojanovic This has some issues, if you can fix that we can merge in. |
Hey @ryanwarsaw metareview: it's easier to edit later if you list the issues in the PR the line numbers- |
|
See review notes
… On Feb 4, 2019, at 6:13 PM, Liz Howard ***@***.***> wrote:
@Stefan-Stojanovic This has some issues, if you can fix that we can merge in.
Hey Ryan it's easier to edit later if you list the issues in the PR the line numbers-
(idk if you guys did a video call, it's unclear to a casual observer what issues are holding up this PR)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.