Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation es #2

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Translation es #2

wants to merge 17 commits into from

Conversation

sebastiandres
Copy link
Member

Updated pull request with reviewed translation for the first 2 notebooks and automated translation for the other notebooks.

@ncclementi
Copy link
Member

@sebastiandres @labarba I haven't revised the text translation in depth yet. But I have couple of general comments that I think we should address before and have them in mind for future notebooks.

  1. How are we going to named the course in Spanish? I saw the translation is "Computación en Ingeniería". Are we translating that or keeping the original name? (The translation sounds weird to me)
  2. Similar issue with the name of the notebooks. Do we want to translate them or not? (I don't have a strong opinion on this)
  3. When we are working with strings, that originally are in English, do we keep the original or we create an Spanish version (In notebook 1 the "hello world" was translated but the others not)
  4. Terms like string, array, list, etc I think we should keep the word and in parentheses the translation, just because they are part of the python jargon. Then if we refer to "tipo string" when they do type(variable) they'll read "string" and that will match the explanation in the text.
  5. Should we translate the comments in the code cells? I think we should, because they are meant to help the student. Opinions?
  6. I think that the code cells should be run before pushing (notebook 1 doesn't have code cells executed), otherwise if a person only wants to read them in NBviewer they won't see the output.
  7. I think we should merge when the whole module is ready. Meantime keep working on the corresponding branch.
  8. I think that the translation script would be a valuable contribution to the repo, not sure where should it be.

This is what I have for now. If we answer these questions we can start with the changes in the code cells and then move to the details in the text.

@sebastiandres
Copy link
Member Author

  1. How are we going to named the course in Spanish? I saw the translation is "Computación en Ingeniería". Are we translating that or keeping the original name? (The translation sounds weird to me) >>> Same here. How about "Engineering Computations - en español"
  2. Similar issue with the name of the notebooks. Do we want to translate them or not? (I don't have a strong opinion on this) >>> Both options are good to me, too. Translating them carries the meaning but not translating them makes easier to keep track. So it's about being consistent.
  3. When we are working with strings, that originally are in English, do we keep the original or we create an Spanish version (In notebook 1 the "hello world" was translated but the others not) >>> Yes, I'm struggling with this one. I think the more reasonable course of action would be translating them for full comprehension. Right now I kept the same code out of simplicity (should I say laziness? :).
  4. Terms like string, array, list, etc I think we should keep the word and in parentheses the translation, just because they are part of the python jargon. Then if we refer to "tipo string" when they do type(variable) they'll read "string" and that will match the explanation in the text. >>> OK, I agree. It was what I was aiming for.
  5. Should we translate the comments in the code cells? I think we should, because they are meant to help the student. Opinions? >>> Same as 3, should translate them. Point taken.
  6. I think that the code cells should be run before pushing (notebook 1 doesn't have code cells executed), otherwise if a person only wants to read them in NBviewer they won't see the output. >>> OK, I agree. I have the habit of cleaning the notebooks before saving them in order to execute them in front of the students, but it makes sense to run them so they can be read online".
  7. I think we should merge when the whole module is ready. Meantime keep working on the corresponding branch. >>>OK, just wanted to know how it was rendering before going any further.
  8. I think that the translation script would be a valuable contribution to the repo, not sure where should it be. >>> This is tricky, because it's the same script and it would be bad to have it duplicated over the modules repo. So, maybe a gist, or a different repo with engCode_tools?

@labarba
Copy link
Member

labarba commented Apr 25, 2018

On pushing the notebooks with output --- like we did when we were developing the course, we should push without output until all revisions to the content are made. Then push with output at the end. This will keep the diffs more compact.

@ncclementi
Copy link
Member

@sebastiandres What do you mean when you say " I want to see how the notebooks render". You can check that by picking the right branch in github or the link of the notebook in NBviewer.

@sebastiandres
Copy link
Member Author

sebastiandres commented Apr 26, 2018

D'oh! All settled then!
I think it could be cool if we put badges for the languages, so people can switch from en to es easily. I'll do it in the translation branch and see how it works:
Generic badge
Generic badge

@labarba
Copy link
Member

labarba commented Apr 27, 2018

And where would you put the badges? In the README for that particular folder?

The language name should probably be in its own language (English, Español, Français).

@sebastiandres
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants