Implement voucher shortcut buttons #962
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
weeman1337
commented
Jul 25, 2022
•
weeman1337
commented
- migrate to Twig template
marudor
reviewed
Oct 1, 2022
| /** | ||
| * Handles +1 voucher clicks. | ||
| */ | ||
| document.addEventListener('click', async (event) => { |
There was a problem hiding this comment.
Bitte nicht auf document den click registrieren. Sondern nur auf den Elementen die du unten prüfst.
Dann wird auch nicht jeder click hier durch gehauen.
marudor
reviewed
Oct 1, 2022
| const dataset = element.dataset; | ||
|
|
||
| if ( | ||
| typeof dataset.voucherAmount === 'undefined' |
There was a problem hiding this comment.
dataset.voucherAmount == null
null und undefined sind nur gegenseitig equivalent => damit wird automatisch auf null und auf undefined geprüft. Braucht also kein typeof
marudor
reviewed
Oct 1, 2022
| try { | ||
| csrfToken = getCSRFToken(); | ||
| } catch (e) { | ||
| console.log(e); |
|
Also this branch has to be rebased as it has merge conflicts @weeman1337 ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.