-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Use references in shifts list, added shift types endpoints #1356
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- in references names in addition to ids would be helpful
- change title of shifts to name
- please change type to angeltype in shiftentries
{
"entries": [
{
"users": [],
"type": { "id": 1 },
"needs": 2
}
]
}
239fccd
to
3befc73
Compare
I don't get all shifts with the angeltype from /angeltypes/{id}/shifts 4 is not equal 72 Edit: Moved to issue #1392 |
please add at least Description to locations (like angeltypes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the comments above
@xuwhite The current model does not have a good place for that without restructuring
Thats the tshirt size as per documentation, i could change the key to
done |
please do so |
than I would prefer to not show the user in a freeloaded shift |
Its implemented and needed a bigger change (grouping entries by angeltype and then user to show that state) but here it is |
…ming * Use reference to objects instead of complete data set * References contain an id and optionally a name * Renamed title to name in news and shift resources * Renamed type to angeltype in shift entries * Added host placeholder to openapi spec
This change is definitely needed to improve the file size for example for room shift endpoints as they are currently too big with tons of redundant datasets
tshirt
totshirt_size
(breaking response structure)