show users with info as arrived #1327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuwhite
reviewed
Jan 7, 2024
| @@ -899,7 +899,7 @@ function User_Nick_render($user, $plain = false) | |||
| return render_profile_link( | |||
| '<span class="icon-icon_angel"></span> ' . htmlspecialchars($user->displayName) . '</a>', | |||
| $user->id, | |||
| ($user->state->arrived ? '' : 'text-muted') | |||
| ($user->state->arrived || $user->state->user_info ? '' : 'text-muted') | |||
There was a problem hiding this comment.
Suggested change
| ($user->state->arrived || $user->state->user_info ? '' : 'text-muted') | |
| ($user->state->arrived ? '' : 'text-muted') |
There was a problem hiding this comment.
That change would make it again obvious to any other angel that this one has a special state -> thats what i mean with "information leaks"
MyIgel
added
the
Status: Needs discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "improves" the workaround introduced in the 37C3 by making the output more consistent.
The interesting question here is if we have more "information leaks" somewhere else when implementing this state output.